Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove important metadata component #3414

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove important metadata component #3414

wants to merge 2 commits into from

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Nov 11, 2024 •
edited
Loading

What

Remove important metadata component

Why

It can be replaced with the metadata block component.

Visual changes

Before

www gov uk_government_speeches_government-at-your-service-ben-gummer-speech(iPad Pro)

After

government-frontend dev gov uk_government_speeches_government-at-your-service-ben-gummer-speech(iPad Pro)

Before (with title)

www gov uk_government_statistics_announcements_core-statistics-book-august-2018(iPad Pro)

After (with title)

government-frontend dev gov uk_government_statistics_announcements_core-statistics-book-august-2018(iPad Pro)

Before

www gov uk_international-development-funding_global-innovation-fund(iPad Pro)

After

government-frontend dev gov uk_international-development-funding_global-innovation-fund(iPad Pro) (1)

Anything else

See alphagov/govuk_publishing_components#4383

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 12:42 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from 85a1d82 to c8043e0 Compare November 11, 2024 13:28
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 13:28 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from c8043e0 to e3fca48 Compare November 11, 2024 13:38
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 13:38 Inactive
@jon-kirwan jon-kirwan mentioned this pull request Nov 11, 2024
Merged
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from e3fca48 to b08d095 Compare November 11, 2024 14:42
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 14:42 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from b08d095 to eee399b Compare November 12, 2024 11:15
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 12, 2024 11:15 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 12, 2024 14:33 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from f85aed6 to 282fd1e Compare November 12, 2024 15:08
@govuk-ci govuk-ci had a problem deploying to government-frontend-pr-3414 November 12, 2024 15:08 Failure
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from 282fd1e to e31543a Compare November 12, 2024 15:08
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 12, 2024 15:09 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from e31543a to 2cdf473 Compare November 13, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-kirwan @govuk-ci